I think it's counterproductive for public office holders to divest everything.
I once worked for a cabinet minister in Alberta. At that time, Peter Lougheed was the premier. At that time, in 1972, he required all his cabinet ministers to sell all their stocks and bonds, including my minister, who had to sell his penny stocks and bonds. I think that was overreach, but in those days we hadn't thought of better ways of preventing real conflicts of interest. We were in the early days.
I think the current regime is much better. It makes it more attractive for good people to get involved in politics.