The date on which the seat became vacant would not be the determinative thing. Rather, the date on which the Governor General issues a writ for the by-election would be the determinant factor in whether the old or the new legislation applies.
On May 28th, 2018. See this statement in context.